Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PST-1796: Add dry-run mode #12

Merged
merged 3 commits into from
Jul 11, 2024
Merged

PST-1796: Add dry-run mode #12

merged 3 commits into from
Jul 11, 2024

Conversation

romantmb
Copy link
Contributor

@romantmb romantmb marked this pull request as ready for review July 11, 2024 08:41
@romantmb romantmb requested a review from janvanicek July 11, 2024 08:41
Copy link

@janvanicek janvanicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zajímá mě ta změna $listTables, plus jen nějaký drobný cleanup v commitech.

Btw datadir testy jsem viděl prvně a trochu jsem nejdřív z tvých změn nechápal, dokud jsem si nenašel https://github.com/keboola/datadir-tests 😃

src/Strategy/SapiMigrate.php Show resolved Hide resolved
src/Strategy/SapiMigrate.php Show resolved Hide resolved
src/Config.php Outdated Show resolved Hide resolved
@romantmb romantmb requested a review from janvanicek July 11, 2024 12:21
Copy link

@janvanicek janvanicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romantmb romantmb merged commit 8862504 into master Jul 11, 2024
4 checks passed
@romantmb romantmb deleted the roman-pst-1796 branch July 11, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants